Increase the timeout when batch deleting permissions #12276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjnilsson
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
This is the first thing deleted in rabbit_vhost:delete/2 so calling rabbitmqctl delete_vhost myvhost against a node in a minority will hang with this change. I think that's ok but for cluster_minority_SUITE we will need to change the delete_vhost case to pass a timeout. Something like:
delete_vhost(Config) ->
?assertError(
{erpc, timeout},
rabbit_ct_broker_helpers:rpc(
Config, 0,
rabbit_vhost, delete, [<<"vhost1">>, <<"acting-user">>], 1_000)).
the-mikedavis
approved these changes
Sep 12, 2024
michaelklishin
approved these changes
Sep 12, 2024
michaelklishin
added a commit
that referenced
this pull request
Sep 12, 2024
Increase the timeout when batch deleting permissions (backport #12276)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deleting a vhost with many user/topic permissions (10k-100k users with one permission each) is very slow in the current implementation of Khepri.
khepri_tree:eval_keep_while_conditionsis particularly slow, mainly on OS X but it is also a bit slower in Linux (tested in Ubuntu) than the equivalent Mnesia operation to delete the permissions.This PR allows the
rabbitmqctl delete_vhost <vhost>command to finish without a timeout, even if still equally slow.